Messages in this thread Patch in this message | | | Date | Sat, 29 Jun 2019 16:06:03 +0530 | From | Hariprasad Kelam <> | Subject | [PATCH 08/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone |
| |
fix below issues reported by checkpatch
CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> --- drivers/staging/rtl8723bs/hal/hal_phy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_phy.c b/drivers/staging/rtl8723bs/hal/hal_phy.c index ebaefca..520f860 100644 --- a/drivers/staging/rtl8723bs/hal/hal_phy.c +++ b/drivers/staging/rtl8723bs/hal/hal_phy.c @@ -81,7 +81,7 @@ bool PHY_RFShadowCompare(IN PADAPTER Adapter, IN u8 eRFPath, IN u32 Offset) { u32 reg; /* Check if we need to check the register */ - if (RF_Shadow[eRFPath][Offset].Compare == true) { + if (RF_Shadow[eRFPath][Offset].Compare) { reg = rtw_hal_read_rfreg(Adapter, eRFPath, Offset, bRFRegOffsetMask); /* Compare shadow and real rf register for 20bits!! */ if (RF_Shadow[eRFPath][Offset].Value != reg) { @@ -100,9 +100,9 @@ bool PHY_RFShadowCompare(IN PADAPTER Adapter, IN u8 eRFPath, IN u32 Offset) void PHY_RFShadowRecorver(IN PADAPTER Adapter, IN u8 eRFPath, IN u32 Offset) { /* Check if the address is error */ - if (RF_Shadow[eRFPath][Offset].ErrorOrNot == true) { + if (RF_Shadow[eRFPath][Offset].ErrorOrNot) { /* Check if we need to recorver the register. */ - if (RF_Shadow[eRFPath][Offset].Recorver == true) { + if (RF_Shadow[eRFPath][Offset].Recorver) { rtw_hal_write_rfreg(Adapter, eRFPath, Offset, bRFRegOffsetMask, RF_Shadow[eRFPath][Offset].Value); /* RT_TRACE(COMP_INIT, DBG_LOUD, */ -- 2.7.4
| |