Messages in this thread | | | Date | Wed, 17 Apr 2019 12:19:47 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v3 3/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller |
| |
On Wed, Apr 17, 2019 at 06:20:58AM -0300, Pablo Greco wrote: > &pio { > pinctrl-names = "default"; > pinctrl-0 = <&clk_out_a_pin>; > + vcc-pa-supply = <®_aldo2>; > + vcc-gmac-phy-supply = <®_dc1sw>; > +};
The PIO banks regulators addition should be in a separate patch. Otherwise, the comments I made on patch 1 still apply.
Maxime
-- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |