Messages in this thread | | | Date | Wed, 17 Apr 2019 12:17:57 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v3 1/7] ARM: dts: sun8i: r40: bananapi-m2-ultra: Tie GMAC regulators to the PIO |
| |
Hi,
On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote: > When the GMAC support was added to the bananapi-m2-ultra, regulators > weren't tied to the pinctrl. Fix that. > > Signed-off-by: Pablo Greco <pgreco@centosproject.org> > --- > arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > index c488aaa..3da3598 100644 > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > @@ -201,6 +201,8 @@ > &pio { > pinctrl-names = "default"; > pinctrl-0 = <&clk_out_a_pin>; > + vcc-pa-supply = <®_aldo2>;
You should list all the regulators that are needed for all the pin banks to operate properly, not just PA
> + vcc-gmac-phy-supply = <®_dc1sw>;
I'm not sure what that is supposed to do?
Maxime
-- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |