Messages in this thread Patch in this message | | | From | zhong jiang <> | Subject | [RESEND PATCH] error-injection: remove meaningless null pointer check before debugfs_remove_recursive | Date | Fri, 21 Sep 2018 09:46:44 +0800 |
| |
debugfs_remove_recursive has taken the null pointer into account. just remove the null check before debugfs_remove_recursive.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- kernel/fail_function.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/fail_function.c b/kernel/fail_function.c index bc80a4e..17f75b5 100644 --- a/kernel/fail_function.c +++ b/kernel/fail_function.c @@ -173,8 +173,7 @@ static void fei_debugfs_remove_attr(struct fei_attr *attr) struct dentry *dir; dir = debugfs_lookup(attr->kp.symbol_name, fei_debugfs_dir); - if (dir) - debugfs_remove_recursive(dir); + debugfs_remove_recursive(dir); } static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs) -- 1.7.12.4
| |