Messages in this thread Patch in this message | | | From | zhong jiang <> | Subject | [PATCH] misc: remove meaningless null check before kfree | Date | Fri, 17 Aug 2018 11:42:35 +0800 |
| |
kfree has taken null pointer into account. so check the null pointer before kfree is meaningless.
Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/misc/sgi-xp/xpc_partition.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/sgi-xp/xpc_partition.c b/drivers/misc/sgi-xp/xpc_partition.c index 0c3ef6f..3eba1c4 100644 --- a/drivers/misc/sgi-xp/xpc_partition.c +++ b/drivers/misc/sgi-xp/xpc_partition.c @@ -98,8 +98,7 @@ len = L1_CACHE_ALIGN(len); if (len > buf_len) { - if (buf_base != NULL) - kfree(buf_base); + kfree(buf_base); buf_len = L1_CACHE_ALIGN(len); buf = xpc_kmalloc_cacheline_aligned(buf_len, GFP_KERNEL, &buf_base); -- 1.7.12.4
| |