Messages in this thread Patch in this message | | | From | Benjamin Gaignard <> | Subject | [PATCH v2] base: core: Remove WARN_ON from link dependencies check | Date | Mon, 16 Jul 2018 11:59:52 +0200 |
| |
In some cases the link between between customer and supplier already exist, for example when a device use it parent as supplier [1]. Do not warn about already existing dependencies because device_link_add() take care of this case.
[1] https://lkml.org/lkml/2018/7/9/356
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Mark Brown <broonie@kernel.org> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> --- drivers/base/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c index df3e1a44707a..fcdc17f0f349 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -105,7 +105,7 @@ static int device_is_dependent(struct device *dev, void *target) struct device_link *link; int ret; - if (WARN_ON(dev == target)) + if (dev == target) return 1; ret = device_for_each_child(dev, target, device_is_dependent); @@ -113,7 +113,7 @@ static int device_is_dependent(struct device *dev, void *target) return ret; list_for_each_entry(link, &dev->links.consumers, s_node) { - if (WARN_ON(link->consumer == target)) + if (link->consumer == target) return 1; ret = device_is_dependent(link->consumer, target); -- 2.15.0
| |