lkml.org 
[lkml]   [2018]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] uart: fix race between uart_put_char() and uart_shutdown()
On Thu, Jul 12, 2018 at 09:08:22AM -0600, Tycho Andersen wrote:
> On Thu, Jul 12, 2018 at 05:04:38PM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jul 11, 2018 at 10:07:44AM -0600, Tycho Andersen wrote:
> > > + if (uport)
> > > + spin_lock_irqsave(&uport->lock, flags);
> >
> > That's the same thing as just calling uart_port_lock(), why aren't you
> > doing that?
>
> Because the compiler can't seem to "see" through the macros/ref calls,
> and I get the warning I mentioned here if I use them:
>
> https://lkml.org/lkml/2018/7/6/840

What horrible version of gcc are you using that give you that? Don't
open-code things just because of a broken compiler.

thanks,

greg k-h
\
 
 \ /
  Last update: 2018-07-15 22:06    [W:0.101 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site