Messages in this thread | | | Date | Thu, 12 Jul 2018 09:08:22 -0600 | From | Tycho Andersen <> | Subject | Re: [PATCH v4] uart: fix race between uart_put_char() and uart_shutdown() |
| |
On Thu, Jul 12, 2018 at 05:04:38PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 11, 2018 at 10:07:44AM -0600, Tycho Andersen wrote: > > + if (uport) > > + spin_lock_irqsave(&uport->lock, flags); > > That's the same thing as just calling uart_port_lock(), why aren't you > doing that?
Because the compiler can't seem to "see" through the macros/ref calls, and I get the warning I mentioned here if I use them:
https://lkml.org/lkml/2018/7/6/840
Tycho
| |