Messages in this thread Patch in this message | | | Date | Mon, 25 Jun 2018 16:44:30 -0600 | From | Jason Gunthorpe <> | Subject | [PATCH RESEND] clang-format: Set IndentWrappedFunctionNames false |
| |
The true option causes this indenting for functions:
static struct something_very_very_long * function(void *arg) {
While a quick survey suggests that the usual Linux fallback is the GNU style:
static struct something_very_very_long * function(void *arg) {
Eg as seen in:
kernel/cpu.c kernel/fork.c etc
Acked-by: Joe Perches <joe@perches.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> --- .clang-format | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Resending outside the merge window with no change..
If there is no clear upstream path for this file (it has no MAINTAINERS entry?) I could take it to Linus via the rdma.git tree, eg as a 'collectively maintained' file.
Would prefer Miguel's Ack to do that though. Looks like Andrew Morton took the original patch introducing the file?
Thanks, Jason
diff --git a/.clang-format b/.clang-format index faffc0d5af4eeb..1d5da22e0ba50c 100644 --- a/.clang-format +++ b/.clang-format @@ -382,7 +382,7 @@ IncludeIsMainRegex: '(Test)?$' IndentCaseLabels: false #IndentPPDirectives: None # Unknown to clang-format-5.0 IndentWidth: 8 -IndentWrappedFunctionNames: true +IndentWrappedFunctionNames: false JavaScriptQuotes: Leave JavaScriptWrapImports: true KeepEmptyLinesAtTheStartOfBlocks: false -- 2.17.0
| |