lkml.org 
[lkml]   [2018]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC 0/3] iommu/iova: Unsafe locking in find_iova()
Date
find_iova() looks to be using a bad locking practice: it locks the
returned iova only for the search time.
And looking in code, the element can be removed from the tree and freed
under rbtree lock. That happens during memory hot-unplug and cleanup on
module removal.
Here I cleanup users of the function and delete it.

Dmitry Safonov (3):
iommu/iova: Find and split iova under rbtree's lock
iommu/iova: Make free_iova() atomic
iommu/iova: Remove find_iova()

drivers/iommu/intel-iommu.c | 14 +++----------
drivers/iommu/iova.c | 48 +++++++++++++++++----------------------------
include/linux/iova.h | 17 ++++------------
3 files changed, 25 insertions(+), 54 deletions(-)

--
2.13.6

\
 
 \ /
  Last update: 2018-06-21 20:08    [W:3.524 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site