Messages in this thread | | | From | Benjamin Herrenschmidt <> | Subject | [RFC PATCH 0/5] FSI scom driver overhaul | Date | Tue, 12 Jun 2018 15:19:06 +1000 |
| |
The current FSI scom driver is a bit too simplistic (and buggy). This fixes a locking bug, cleans a few things up, then overhaul the driver more thoroughly by providing proper support for the different type of SCOM accesses (direct and indirect), handling errors properly in the read/write interface, and adding a lower level ioctl interface needed by system debugger (such as cronus) that need to be able to access the raw status register content resulting from the access attempt and do their own error handling.
I will send patches separately for pdbg and cronus to use the new debugger interface.
Note: It is unfortunate that the read/write interface does NOT use the same addressing scheme as the host-side equivalent xscom debugfs interface. However I didn't want to change the user ABI by "fixing" this as I'm not entirely sure what other users we might have of that existing interface.
The patches apply on top of the other FSI changes posted recently and at this point are meant to discuss the new user API.
| |