Messages in this thread | | | Subject | Re: [RFC PATCH 0/5] Hexagon remoteproc spring cleaning | From | Rohit Kumar <> | Date | Fri, 1 Jun 2018 19:03:43 +0530 |
| |
Thanks Bjorn for the cleanup.
I validated PAS and Non- PAS ADSP PIL with the cleanup changes on SDM845.
Adding tag for ADSP PIL.
Reviewed-and-tested-by: Rohit kumar <rohitkr@codeaurora.org>
On 5/23/2018 10:50 AM, Bjorn Andersson wrote: > With the introduction of support for the non-MSA Hexagon WCSS driver from > Sricharan and the non-PAS ADSP driver from Rohit it makes sense to overhaul the > structure of the Qualcomm "Q6V5 drivers". > > The first patch is from Sricharan's series and included here for completeness. > The second patch introduces a set of helper functions, based on the current > state of the qcom_q6v5_pil driver. The third and forth patch migrates the PAS > and the MSA drivers over to using these helpers. Finally a (completely) > reworked version of Sricharan's WCSS remoteproc driver is introduced. > > > With this in place I suggest that we rename qcom_adsp_pil.c to qcom_q6v5_pas.c,
I am making changes for non-PAS ADSP PIL by creating new file. In case you plan to rename qcom_adsp_pil.c to qcom_q6v5_pas, please include that change with this. Also, let me know the filename which we should keep it for non-PAS ADSP PIL driver. > qcom_q6v5_pil.c to qcom_q6v5_msa.c and depending on the details of the non-PAS > ADSP we could potentially combine that into a qcom_q6v5_pil.c - or we carry > them as separate files. I tried comparing qcom_q6v5_pil.c with non-PAS ADSP pil driver. I don't think that we can combine them as there are good amount of code differences. However, we can take a look into it once I post non-PAS ADSP PIL. > > Looking at the remaining non-essential parts of these drivers we have > memory-region handling and halt_axi handling. The prior is actively being > worked on and the latter should (if no better abstraction is presented) be > possible to just put in the new qcom_q6v5.c. >
Thanks, Rohit
-- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
| |