lkml.org 
[lkml]   [2018]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver
    On 22-05-18, 22:20, Bjorn Andersson wrote:

    > +static int q6v5_wcss_reset(struct q6v5_wcss *wcss)
    > +{
    > + int ret;
    > + u32 val;
    > + int i;
    > +
    > + /* Assert resets, stop core */
    > + val = readl(wcss->reg_base + QDSP6SS_RESET_REG);
    > + val |= Q6SS_CORE_ARES | Q6SS_BUS_ARES_ENABLE | Q6SS_STOP_CORE;
    > + writel(val, wcss->reg_base + QDSP6SS_RESET_REG);
    > +
    > + /* BHS require xo cbcr to be enabled */
    > + val = readl(wcss->reg_base + QDSP6SS_XO_CBCR);
    > + val |= 0x1;
    > + writel(val, wcss->reg_base + QDSP6SS_XO_CBCR);

    As commented on previous patch, it would help IMO to add a modify() wrapper
    here which would perform read, modify and write.

    Looking at the patch, few other comments would be applicable too, so would be
    great if you/Sricharan can update this

    --
    ~Vinod

    \
     
     \ /
      Last update: 2018-05-23 08:06    [W:3.293 / U:0.864 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site