Messages in this thread Patch in this message | | | From | Heinrich Schuchardt <> | Subject | [BUG] scripts/checkpatch.pl: false positive missing parentheses | Date | Mon, 7 May 2018 20:31:05 +0200 |
| |
This patch creates a false positive: ERROR: Macros with complex values should be enclosed in parentheses
Here we define a constant that can be used to initialize a structure. Adding parentheses would lead to a compile time error: error: braced-group within expression allowed only inside a function
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- foo.h | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 foo.h
diff --git a/foo.h b/foo.h new file mode 100644 index 000000000000..e2cba533f065 --- /dev/null +++ b/foo.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: BSD-2 */ +#define EFI_ST_DISK_IMG { 0x00003368, { \ + {0x00000d40, "\x6f\x63\x00\x2f\x2a\x00\x20\x2a"}, /* oc./*. * */ \ + {0x00000d48, "\x00\x20\x2a\x2f\x0a\x00\x09\x7b"}, /* . */...{ */ \ + {0x00000d50, "\x30\x78\x25\x30\x38\x7a\x78\x2c"}, /* 0x%08zx, */ \ + {0x00000d58, "\x20\x22\x00\x5c\x78\x25\x30\x32"}, /* ".\x%02 */ \ + {0x00000d60, "\x78\x00\x20\x2a\x2f\x20\x5c\x00"}, /* x. */ \. */ \ + {0, NULL} } } -- 2.17.0
| |