Messages in this thread | | | Date | Fri, 2 Mar 2018 04:08:04 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net 4/4] net: dsa: mv88e6xxx: Utilize strncpy() for ethtool::get_strings |
| |
On Thu, Mar 01, 2018 at 04:25:29PM -0800, Florian Fainelli wrote: > Do not use memcpy() which is not safe, but instead use strncpy() which > will make sure that the string is NUL terminated (in the Linux > implementation) if the string is smaller than the length specified. This > fixes KASAN out of bounds warnings while fetching port statistics. > > Fixes: f5e2ed022dff ("dsa: mv88e6xxx: Add Second back of statistics")
I'm sure it goes back much further than that.
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |