lkml.org 
[lkml]   [2018]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net 1/4] net: dsa: b53: Use strncpy() for ethtool::get_strings
    Date
    Do not use memcpy() which is not safe, but instead use strncpy() which
    will make sure that the string is NUL terminated (in the Linux
    implementation) if the string is smaller than the length specified. This
    fixes KASAN out of bounds warnings while fetching port statistics.

    Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    ---
    drivers/net/dsa/b53/b53_common.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
    index db830a1141d9..c64ebb82df83 100644
    --- a/drivers/net/dsa/b53/b53_common.c
    +++ b/drivers/net/dsa/b53/b53_common.c
    @@ -814,8 +814,8 @@ void b53_get_strings(struct dsa_switch *ds, int port, uint8_t *data)
    unsigned int i;

    for (i = 0; i < mib_size; i++)
    - memcpy(data + i * ETH_GSTRING_LEN,
    - mibs[i].name, ETH_GSTRING_LEN);
    + strncpy(data + i * ETH_GSTRING_LEN,
    + mibs[i].name, ETH_GSTRING_LEN);
    }
    EXPORT_SYMBOL(b53_get_strings);

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-02 01:27    [W:2.922 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site