lkml.org 
[lkml]   [2018]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/9] perf utils: add support for arch standard events
On Wed, Feb 07, 2018 at 01:45:00AM +0800, John Garry wrote:

SNIP

> +static void fixup_field(char *from, char **to)
> +{
> + *to = malloc(strlen(from));
> +
> + strcpy(*to, from);
> +}
> +
> +#define EVENT_PREFIX "event="
> +
> +#define TRY_FIXUP_FIELD(string) do { if (es->string && !*string)\
> + fixup_field(es->string, string); \
> +} while (0)

please indent the code in the macro like normal code

> +
> +static int
> +try_fixup(const char *fn, char *arch_std, char **event, char **desc,
> + char **name, char **long_desc, char **pmu, char **filter,
> + char **perpkg, char **unit, char **metric_expr, char **metric_name,
> + char **metric_group)
> +{
> + /* try to find matching event from arch standard values */
> + struct event_struct *es;
> +
> + list_for_each_entry(es, &arch_std_events, list) {
> + if (!strcmp(arch_std, es->event+strlen(EVENT_PREFIX))) {

you could use just sizeof(EVENT_PREFIX). no need to call strlen

jirka

\
 
 \ /
  Last update: 2018-02-08 14:54    [W:0.118 / U:0.528 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site