lkml.org 
[lkml]   [2018]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/9] perf utils: add support for arch standard events
From
Date
On 08/02/2018 13:55, Jiri Olsa wrote:
> On Wed, Feb 07, 2018 at 01:45:00AM +0800, John Garry wrote:
>
> SNIP
>
>>
>> +static int is_json_file(const char *name)
>> +{
>> + const char *suffix;
>> +
>> + if (strlen(name) < 5)
>> + return 0;
>> +
>> + suffix = name + strlen(name) - 5;
>> +
>> + if (strncmp(suffix, ".json", 5) == 0)
>> + return 1;
>> + return 0;
>> +}
>> +
>> +static int preprocess_arch_std_files(const char *fpath, const struct stat *sb,
>> + int typeflag, struct FTW *ftwbuf)
>> +{
>> + int level = ftwbuf->level;
>> + int is_file = typeflag == FTW_F;
>> +
>> + if (level == 1 && is_file && is_json_file(fpath))
>> + return json_events(fpath, save_arch_std_events, (void *)sb);
>
> so any .json file will pass..

Yes, so according to the scheme any architecture JSONs should be placed
in the arch root folder.

just wondering you'd want to put
> some name restriction for recomended events file like this -recomended
> suffix you used later.. but that can be added later in case we'll
> need some other json files in here ;-)

Sorry, but I don't see what the naming restriction would mean in practice.

Thanks,
John

>
> jirka
>
> .
>


\
 
 \ /
  Last update: 2018-02-08 16:27    [W:0.144 / U:0.056 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site