Messages in this thread Patch in this message | | | Date | Tue, 13 Feb 2018 10:52:58 -0600 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH] iio: adc: ina2xx: Use 64-bit arithmetic instead of 32-bit |
| |
Add suffix ULL to constant 1000 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type u64 (64 bits, unsigned).
The expression 1000 * sampling_us is currently being evaluated using 32-bit arithmetic.
Addresses-Coverity-ID: 1463793 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/iio/adc/ina2xx-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c index 0635a79..8649700 100644 --- a/drivers/iio/adc/ina2xx-adc.c +++ b/drivers/iio/adc/ina2xx-adc.c @@ -810,7 +810,7 @@ static int ina2xx_capture_thread(void *data) * multiple times, i.e. samples are dropped. */ do { - timespec64_add_ns(&next, 1000 * sampling_us); + timespec64_add_ns(&next, 1000ULL * sampling_us); delta = timespec64_sub(next, now); delay_us = div_s64(timespec64_to_ns(&delta), 1000); } while (delay_us <= 0); -- 2.7.4
| |