lkml.org 
[lkml]   [2018]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2] tick/broadcast: Remove redundant code in tick_check_new_device()
Hi Maintainers,

When cleanup my mailbox for free space, I see this patch is missed in upstream.
Checked code again, I think that code indeed could be removed safely.

So could anyone Ack or NAK it? Thanks very much.

Regards
Zhenzhong

----- zhenzhong.duan@oracle.com wrote:

> There is no way a timer used as broadcast clockevent device is also
> used as
> percpu tick clockevent device currently.
>
> -v2: remove meaningless description suggested by tglx
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> ---
> kernel/time/tick-common.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
> index 49edc1c..9bcc866 100644
> --- a/kernel/time/tick-common.c
> +++ b/kernel/time/tick-common.c
> @@ -320,13 +320,8 @@ void tick_check_new_device(struct
> clock_event_device *newdev)
>
> /*
> * Replace the eventually existing device by the new
> - * device. If the current device is the broadcast device, do
> - * not give it back to the clockevents layer !
> + * device.
> */
> - if (tick_is_broadcast_device(curdev)) {
> - clockevents_shutdown(curdev);
> - curdev = NULL;
> - }
> clockevents_exchange_device(curdev, newdev);
> tick_setup_device(td, newdev, cpu, cpumask_of(cpu));
> if (newdev->features & CLOCK_EVT_FEAT_ONESHOT)
> --
> 1.7.3

\
 
 \ /
  Last update: 2018-12-04 10:22    [W:0.027 / U:1.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site