Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Mattias Jacobsson <> | Subject | [PATCH] perf tools: util: remove redundant va_end() in strbuf_addv() | Date | Sat, 29 Dec 2018 15:17:50 +0100 |
| |
Each call to va_copy() should have one, and only one, corresponding call to va_end(). In strbuf_addv() some code paths result in va_end() getting called multiple times. Remove the superfluous va_end().
Fixes: ce49d8436cff ("perf strbuf: Match va_{add,copy} with va_end") Signed-off-by: Mattias Jacobsson <2pi@mok.nu> --- tools/perf/util/strbuf.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/tools/perf/util/strbuf.c b/tools/perf/util/strbuf.c index 9005fbe0780e..23092fd6451d 100644 --- a/tools/perf/util/strbuf.c +++ b/tools/perf/util/strbuf.c @@ -109,7 +109,6 @@ static int strbuf_addv(struct strbuf *sb, const char *fmt, va_list ap) return ret; } len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, ap_saved); - va_end(ap_saved); if (len > strbuf_avail(sb)) { pr_debug("this should not happen, your vsnprintf is broken"); va_end(ap_saved); -- 2.20.1
| ![\](/images/icornerr.gif) |