Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Kangjie Lu <> | Subject | [PATCH] media: mt312: fix a missing check of mt312 reset | Date | Fri, 21 Dec 2018 01:07:20 -0600 |
| |
mt312_reset() may fail. Although it is called in the end of mt312_set_frontend(), we better check its status and return its error code upstream instead of 0.
Signed-off-by: Kangjie Lu <kjlu@umn.edu> --- drivers/media/dvb-frontends/mt312.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/mt312.c b/drivers/media/dvb-frontends/mt312.c index 03e74a729168..bfbb879469f2 100644 --- a/drivers/media/dvb-frontends/mt312.c +++ b/drivers/media/dvb-frontends/mt312.c @@ -645,7 +645,9 @@ static int mt312_set_frontend(struct dvb_frontend *fe) if (ret < 0) return ret; - mt312_reset(state, 0); + ret = mt312_reset(state, 0); + if (ret < 0) + return ret; return 0; } -- 2.17.2 (Apple Git-113)
| ![\](/images/icornerr.gif) |