Messages in this thread Patch in this message | | | From | Paul Gortmaker <> | Subject | [PATCH 07/22] mfd: da9055-core: make it explicitly non-modular | Date | Sun, 2 Dec 2018 23:23:14 -0500 |
| |
The Kconfig currently controlling compilation of this code is:
drivers/mfd/Kconfig:config MFD_DA9055 drivers/mfd/Kconfig- bool "Dialog Semiconductor DA9055 PMIC Support"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only.
The exit function deleted here wasn't even registered with module_exit, so it truly was dead code.
We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments.
We replace module.h with init.h and export.h ; the latter since the file does export some symbols
Cc: Support Opensource <support.opensource@diasemi.com> Cc: Lee Jones <lee.jones@linaro.org> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/mfd/da9055-core.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c index 177e65a12c12..b55f13061547 100644 --- a/drivers/mfd/da9055-core.c +++ b/drivers/mfd/da9055-core.c @@ -11,7 +11,8 @@ * option) any later version. */ -#include <linux/module.h> +#include <linux/init.h> +#include <linux/export.h> #include <linux/device.h> #include <linux/input.h> #include <linux/irq.h> @@ -416,13 +417,3 @@ int da9055_device_init(struct da9055 *da9055) mfd_remove_devices(da9055->dev); return ret; } - -void da9055_device_exit(struct da9055 *da9055) -{ - regmap_del_irq_chip(da9055->chip_irq, da9055->irq_data); - mfd_remove_devices(da9055->dev); -} - -MODULE_DESCRIPTION("Core support for the DA9055 PMIC"); -MODULE_LICENSE("GPL"); -MODULE_AUTHOR("David Dajun Chen <dchen@diasemi.com>"); -- 2.7.4
| |