lkml.org 
[lkml]   [2018]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/22] mfd: tps65090: Make it explicitly non-modular
    Date
    The Kconfig currently controlling compilation of this code is:

    drivers/mfd/Kconfig:config MFD_TPS65090
    drivers/mfd/Kconfig: bool "TI TPS65090 Power Management chips"

    ...meaning that it currently is not being built as a module by anyone.

    Lets remove the modular code that is essentially orphaned, so that
    when reading the driver there is no doubt it is builtin-only.

    We explicitly disallow a driver unbind, since that doesn't have a
    sensible use case anyway, and it allows us to drop the ".remove"
    code for non-modular drivers.

    Since module_init was not in use by this code, the init ordering
    remains unchanged with this commit.

    Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

    We also delete the MODULE_LICENSE tag etc. since all that information
    was (or is now) contained at the top of the file in the comments.

    Cc: Lee Jones <lee.jones@linaro.org>
    Cc: Venu Byravarasu <vbyravarasu@nvidia.com>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/mfd/tps65090.c | 30 +++++-------------------------
    1 file changed, 5 insertions(+), 25 deletions(-)

    diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
    index f13e4cd06e89..6968df4d7828 100644
    --- a/drivers/mfd/tps65090.c
    +++ b/drivers/mfd/tps65090.c
    @@ -2,7 +2,9 @@
    * Core driver for TI TPS65090 PMIC family
    *
    * Copyright (c) 2012, NVIDIA CORPORATION. All rights reserved.
    -
    + *
    + * Author: Venu Byravarasu <vbyravarasu@nvidia.com>
    + *
    * This program is free software; you can redistribute it and/or modify it
    * under the terms and conditions of the GNU General Public License,
    * version 2, as published by the Free Software Foundation.
    @@ -19,7 +21,7 @@
    #include <linux/interrupt.h>
    #include <linux/irq.h>
    #include <linux/kernel.h>
    -#include <linux/module.h>
    +#include <linux/init.h>
    #include <linux/mutex.h>
    #include <linux/slab.h>
    #include <linux/i2c.h>
    @@ -171,7 +173,6 @@ static const struct of_device_id tps65090_of_match[] = {
    { .compatible = "ti,tps65090",},
    {},
    };
    -MODULE_DEVICE_TABLE(of, tps65090_of_match);
    #endif

    static int tps65090_i2c_probe(struct i2c_client *client,
    @@ -236,30 +237,19 @@ static int tps65090_i2c_probe(struct i2c_client *client,
    return ret;
    }

    -static int tps65090_i2c_remove(struct i2c_client *client)
    -{
    - struct tps65090 *tps65090 = i2c_get_clientdata(client);
    -
    - mfd_remove_devices(tps65090->dev);
    - if (client->irq)
    - regmap_del_irq_chip(client->irq, tps65090->irq_data);
    -
    - return 0;
    -}

    static const struct i2c_device_id tps65090_id_table[] = {
    { "tps65090", 0 },
    { },
    };
    -MODULE_DEVICE_TABLE(i2c, tps65090_id_table);

    static struct i2c_driver tps65090_driver = {
    .driver = {
    .name = "tps65090",
    + .suppress_bind_attrs = true,
    .of_match_table = of_match_ptr(tps65090_of_match),
    },
    .probe = tps65090_i2c_probe,
    - .remove = tps65090_i2c_remove,
    .id_table = tps65090_id_table,
    };

    @@ -268,13 +258,3 @@ static int __init tps65090_init(void)
    return i2c_add_driver(&tps65090_driver);
    }
    subsys_initcall(tps65090_init);
    -
    -static void __exit tps65090_exit(void)
    -{
    - i2c_del_driver(&tps65090_driver);
    -}
    -module_exit(tps65090_exit);
    -
    -MODULE_DESCRIPTION("TPS65090 core driver");
    -MODULE_AUTHOR("Venu Byravarasu <vbyravarasu@nvidia.com>");
    -MODULE_LICENSE("GPL v2");
    --
    2.7.4
    \
     
     \ /
      Last update: 2018-12-03 05:28    [W:2.399 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site