lkml.org 
[lkml]   [2018]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectASoC: About graph node issue without 'reg' property
Hello Morimoto-san, Mark,

I found that your commit b6f3fc005a2c ("ASoC: simple-card-utils:
fixup asoc_simple_card_get_dai_id() counting") replaced with
of_graph_parse_endpoint(), that needs 'reg' property in each port
that has an endpoint.

Currently devicetrees for UniPhier SoCs have also audio graph nodes [1],
and these graph nodes include an endpoint for each port.
Although the port doesn't have 'reg' property, it has worked fine before.
And after applying the commit, it doesn't work.

It is written in Documentation/devicetree/bindings/graph.txt
that common scheme is to include the 'reg' property.

Maybe I think that we'd better add 'reg' properties to each port,
however, there might be same matter in other SoCs, so I'm not sure
whether your patch breaks the backword compatibility or
our devicetrees are wrong.

I'd be glad if I could hear something about this issue from you.

Thank you,

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi#n348

---
Best Regards,
Kunihiko Hayashi


\
 
 \ /
  Last update: 2018-12-13 11:41    [W:0.046 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site