Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Neil Armstrong <> | Subject | [PATCH] media: cxd2880-spi: fix probe when dvb_attach fails | Date | Thu, 8 Nov 2018 13:44:48 +0100 |
| |
When dvb_attach fails, probe returns 0, and remove crashes afterwards. This patch sets the return value to -ENODEV when attach fails.
Fixes: bd24fcddf6b8 ("media: cxd2880-spi: Add support for CXD2880 SPI interface") Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- drivers/media/spi/cxd2880-spi.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/media/spi/cxd2880-spi.c b/drivers/media/spi/cxd2880-spi.c index 11ce510..c437309 100644 --- a/drivers/media/spi/cxd2880-spi.c +++ b/drivers/media/spi/cxd2880-spi.c @@ -536,6 +536,7 @@ cxd2880_spi_probe(struct spi_device *spi) if (!dvb_attach(cxd2880_attach, &dvb_spi->dvb_fe, &config)) { pr_err("cxd2880_attach failed\n"); + ret = -ENODEV; goto fail_attach; } -- 2.7.4
| ![\](/images/icornerr.gif) |