Messages in this thread Patch in this message | | | Date | Mon, 26 Nov 2018 11:12:29 +0300 | From | Dan Carpenter <> | Subject | [PATCH] misc/pvpanic: fix a NULL vs IS_ERR() check |
| |
The devm_ioremap_resource() function doesn't return NULL, it returns error pointers.
Fixes: 46f934c9a12f ("misc/pvpanic: add support to get pvpanic device info FDT") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/misc/pvpanic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c index 01241ec6a5cd..595ac065b401 100644 --- a/drivers/misc/pvpanic.c +++ b/drivers/misc/pvpanic.c @@ -140,8 +140,8 @@ static int pvpanic_mmio_probe(struct platform_device *pdev) return -EINVAL; base = devm_ioremap_resource(&pdev->dev, mem); - if (base == NULL) - return -EFAULT; + if (IS_ERR(base)) + return PTR_ERR(base); atomic_notifier_chain_register(&panic_notifier_list, &pvpanic_panic_nb); -- 2.11.0
| |