Messages in this thread | | | Date | Tue, 30 Jan 2018 11:08:18 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v3 1/4] dt-bindings: firmware: Add bindings for ZynqMP firmware |
| |
On Wed, Jan 24, 2018 at 03:21:11PM -0800, Jolly Shah wrote: > Add documentation to describe Xilinx ZynqMP firmware driver > bindings. Firmware driver provides an interface to firmware > APIs. Interface APIs can be used by any driver to communicate > to PMUFW (Platform Management Unit). > > Signed-off-by: Jolly Shah <jollys@xilinx.com> > Signed-off-by: Rajan Vaja <rajanv@xilinx.com> > --- > .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > create mode 100644 Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt > > diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt > new file mode 100644 > index 0000000..a7aaf56 > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt > @@ -0,0 +1,16 @@ > +Xilinx Zynq MPSoC Firmware Device Tree Bindings > + > +The zynqmp-firmware node describes the interface to platform firmware.
Please define this a is child of /firmware.
Also, some brief summary of what functions the firmware provides would be nice.
> + > +Required properties: > + - compatible: Must contain: "xlnx,zynqmp-firmware" > + - method: The method of calling the PM-API firmware layer. > + Permitted values are: > + - "smc" : To be used in configurations without a hypervisor > + - "hvc" : To be used when hypervisor is present
Do you really need to support hvc?
> + > +Examples: > + zynqmp_firmware: zynqmp-firmware { > + compatible = "xlnx,zynqmp-firmware"; > + method = "smc"; > + }; > -- > 2.7.4 >
| |