lkml.org 
[lkml]   [2018]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] objtool: Ignore retpoline alternatives
From
Date
On Thu, 2018-01-11 at 09:29 -0800, Linus Torvalds wrote:
> On Thu, Jan 11, 2018 at 8:27 AM, David Woodhouse <dwmw2@infradead.org> wrote:
> >
> >
> >   Ick, numbers. Use .Lfoo_%= instead.
> >
>
> Actually, I think PeterZ is wrong on this one.
>
> First off, we do *not* use %= in inline asms in the kernel yet, and we
> shouldn't start just because of these.
>
> Secondly, we use lots of the the "small numbers for local labels" both
> in inline asm and in *.S files.
>
> I think doing
>
>        jne 1f
>   ...
>   1:
>
> is a _hell_ of a lot more legible than
>
>         jne .LPrefix_%
>     ...
>   .LPrefix_%
>
> unless you have some *major* reason to use an explicit label name.

OK. I'll change it back.
[unhandled content-type:application/x-pkcs7-signature]
\
 
 \ /
  Last update: 2018-01-14 23:24    [W:0.431 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site