Messages in this thread | | | Subject | Re: [PATCH 2/3] objtool: Ignore retpoline alternatives | From | David Woodhouse <> | Date | Thu, 11 Jan 2018 17:43:41 +0000 |
| |
On Thu, 2018-01-11 at 09:29 -0800, Linus Torvalds wrote: > On Thu, Jan 11, 2018 at 8:27 AM, David Woodhouse <dwmw2@infradead.org> wrote: > > > > > > Ick, numbers. Use .Lfoo_%= instead. > > > > Actually, I think PeterZ is wrong on this one. > > First off, we do *not* use %= in inline asms in the kernel yet, and we > shouldn't start just because of these. > > Secondly, we use lots of the the "small numbers for local labels" both > in inline asm and in *.S files. > > I think doing > > jne 1f > ... > 1: > > is a _hell_ of a lot more legible than > > jne .LPrefix_% > ... > .LPrefix_% > > unless you have some *major* reason to use an explicit label name.
OK. I'll change it back. [unhandled content-type:application/x-pkcs7-signature] | |