lkml.org 
[lkml]   [2018]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] objtool: Ignore retpoline alternatives
From
Date
On Thu, 2018-01-11 at 10:33 -0600, Josh Poimboeuf wrote:
> On Thu, Jan 11, 2018 at 04:27:38PM +0000, David Woodhouse wrote:
> >
> > On Wed, 2018-01-10 at 19:48 -0600, Josh Poimboeuf wrote:
> > >
> > >
> > > +#define ANNOTATE_NOSPEC_ALTERNATIVE                            \
> > > +       "999:\n\t"                                              \
> > > +       ".pushsection .discard.nospec\n\t"                      \
> > > +       ".long 999b - .\n\t"                                    \
> > > +       ".popsection\n\t"
> > > +
> >
> >   Ick, numbers. Use .Lfoo_%= instead.
> >
> I seem to recall that not working with inline asm, maybe old versions of
> GCC don't like it or something?  I can try it and see if 0-day bot
> complains.

You just need %= (for inline asm) instead of \@ (for .macro).

I already fixed it up in
http://git.infradead.org/users/dwmw2/linux-retpoline.git/ and will get
nagmail from 0day shortly if it doesn't work :)

(I love you Fengguang)[unhandled content-type:application/x-pkcs7-signature]
\
 
 \ /
  Last update: 2018-01-14 23:24    [W:0.096 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site