lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Add driver to force WMI Thunderbolt controller power status
On Thu, Sep 07, 2017 at 01:47:22PM -0500, Mario Limonciello wrote:

I have a small comment which you might want to consider.

> +static int intel_wmi_thunderbolt_probe(struct wmi_device *wdev)
> +{
> + return sysfs_create_group(&wdev->dev.kobj, &tbt_attribute_group);
> +}
> +
> +static int intel_wmi_thunderbolt_remove(struct wmi_device *wdev)
> +{
> + sysfs_remove_group(&wdev->dev.kobj, &tbt_attribute_group);
> + return 0;
> +}

In order to notify userspace about this, what if you send KOBJ_CHANGE
for the wdev when you add/remove this attribute?

\
 
 \ /
  Last update: 2017-09-08 10:16    [W:1.435 / U:3.448 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site