lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v2] Add driver to force WMI Thunderbolt controller power status
    Date
    > -----Original Message-----
    > From: Mika Westerberg [mailto:mika.westerberg@linux.intel.com]
    > Sent: Friday, September 8, 2017 3:07 AM
    > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
    > Cc: dvhart@infradead.org; LKML <linux-kernel@vger.kernel.org>; platform-driver-
    > x86@vger.kernel.org; Richard Hughes <hughsient@gmail.com>; Yehezkel Bernat
    > <yehezkelshb@gmail.com>
    > Subject: Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power
    > status
    >
    > On Thu, Sep 07, 2017 at 01:47:22PM -0500, Mario Limonciello wrote:
    >
    > I have a small comment which you might want to consider.
    >
    > > +static int intel_wmi_thunderbolt_probe(struct wmi_device *wdev)
    > > +{
    > > + return sysfs_create_group(&wdev->dev.kobj, &tbt_attribute_group);
    > > +}
    > > +
    > > +static int intel_wmi_thunderbolt_remove(struct wmi_device *wdev)
    > > +{
    > > + sysfs_remove_group(&wdev->dev.kobj, &tbt_attribute_group);
    > > + return 0;
    > > +}
    >
    > In order to notify userspace about this, what if you send KOBJ_CHANGE
    > for the wdev when you add/remove this attribute?

    Sure, makes sense to me. I'll send a follow up patch.

    \
     
     \ /
      Last update: 2017-09-08 17:17    [W:4.970 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site