Messages in this thread | | | Date | Thu, 7 Sep 2017 12:44:01 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] dt-bindings: spi: Add Spreadtrum ADI controller documentation |
| |
On Thu, Sep 07, 2017 at 07:03:18PM +0800, Baolin Wang wrote: > On 7 September 2017 at 17:54, Mark Brown <broonie@kernel.org> wrote: > > On Thu, Sep 07, 2017 at 11:29:05AM +0800, Baolin Wang wrote:
> >> The hwspinlock name should be "adi", and I will make it clear in next version.
> > So there's other drivers that might also be accessing this IP block?
> Yes. Other drivers (like regulator, RTC or charger ... ) can access > analog chip (like PMIC) by ADI controller. But the hardware spinlock > is used to synchronize between the multiple subsystems, since we only > have one ADI controller.
If it were other drivers then the kernel should already be doing that but...
> > So does this driver control all the channels or are there other drivers > > (or hardware components) that control some of the other channels?
> The ADI driver only controls 2 software channels (read/write), and > other hardware channels can be controlled by hardware components if we > set the hardware config.
...if it can be configured to allow other things to use it independently then this is fine, just needs a bit more documentation so someone can understand how the bindings and hardware match up. [unhandled content-type:application/pgp-signature] | |