Messages in this thread | | | From | Baolin Wang <> | Date | Fri, 8 Sep 2017 09:57:17 +0800 | Subject | Re: [PATCH 1/2] dt-bindings: spi: Add Spreadtrum ADI controller documentation |
| |
On 7 September 2017 at 19:44, Mark Brown <broonie@kernel.org> wrote: > On Thu, Sep 07, 2017 at 07:03:18PM +0800, Baolin Wang wrote: >> On 7 September 2017 at 17:54, Mark Brown <broonie@kernel.org> wrote: >> > On Thu, Sep 07, 2017 at 11:29:05AM +0800, Baolin Wang wrote: > >> >> The hwspinlock name should be "adi", and I will make it clear in next version. > >> > So there's other drivers that might also be accessing this IP block? > >> Yes. Other drivers (like regulator, RTC or charger ... ) can access >> analog chip (like PMIC) by ADI controller. But the hardware spinlock >> is used to synchronize between the multiple subsystems, since we only >> have one ADI controller. > > If it were other drivers then the kernel should already be doing that > but...
Not only kernel drivers, but also other systems' drivers will access ADI too. So here we need one hardware spinlock to protect, I will add more documentation.
> >> > So does this driver control all the channels or are there other drivers >> > (or hardware components) that control some of the other channels? > >> The ADI driver only controls 2 software channels (read/write), and >> other hardware channels can be controlled by hardware components if we >> set the hardware config. > > ...if it can be configured to allow other things to use it independently > then this is fine, just needs a bit more documentation so someone can > understand how the bindings and hardware match up.
OK. Thanks for your comments.
-- Baolin.wang Best Regards
| |