lkml.org 
[lkml]   [2017]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] thermal/drivers/hisi: Switch to interrupt mode
On Thu, Sep 28, 2017 at 02:57:52PM +0800, Leo Yan wrote:
> Hi Daniel,
>
> On Thu, Sep 28, 2017 at 07:13:44AM +0200, Daniel Lezcano wrote:
> > At this moment, we have both the interrupt setup and the polling enabled. The
> > interrupt does nothing more than forcing an update while the temperature is
> > polled every second.
> >
> > We can do much better than that, threshold is set to 65C in the DT and the
> > passive cooling device enters in the dance when 75C is reached. We need to
> > sample the temperature at 65C in order to let the IPA gather enough values for
> > the PID computation. If the SoC is running at a temperature below 65C, we will
> > be constantly polling for nothing.
> >
> > This patch disables the sensor when the temperature is below 65C and enables it
> > when passing the threshold. It results the thermal sensor driver will have no
> > activity most of the time.
> >
> > Cc: Keerthy <j-keerthy@ti.com>
> > Cc: Leo Yang <leo.yan@linaro.org>
>
> s/Yang/Yan :) Have tested this patch on Hikey at my side:

Oops sorry :)

> Reviewed-by: Leo Yan <leo.yan@linaro.org>
> Tested-by: Leo Yan <leo.yan@linaro.org>


Great! Thanks for testing.

-- Daniel

\
 
 \ /
  Last update: 2017-09-28 09:33    [W:0.040 / U:25.964 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site