Messages in this thread Patch in this message | | | From | Byungchul Park <> | Subject | [PATCH] llist: Put parentheses around parameters of llist_for_each_entry_safe() | Date | Tue, 26 Sep 2017 15:54:51 +0900 |
| |
It would be somewhat safer to put parentheses around parameters of a macro with parameters. Put it.
Signed-off-by: Byungchul Park <byungchul.park@lge.com> --- include/linux/llist.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/llist.h b/include/linux/llist.h index 1957635..e280b297 100644 --- a/include/linux/llist.h +++ b/include/linux/llist.h @@ -183,10 +183,10 @@ static inline void init_llist_head(struct llist_head *list) * reverse the order by yourself before traversing. */ #define llist_for_each_entry_safe(pos, n, node, member) \ - for (pos = llist_entry((node), typeof(*pos), member); \ + for ((pos) = llist_entry((node), typeof(*(pos)), member); \ member_address_is_nonnull(pos, member) && \ - (n = llist_entry(pos->member.next, typeof(*n), member), true); \ - pos = n) + ((n) = llist_entry((pos)->member.next, typeof(*(n)), member), true); \ + (pos) = (n)) /** * llist_empty - tests whether a lock-less list is empty -- 1.9.1
| |