Messages in this thread | | | Subject | Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe() | From | SF Markus Elfring <> | Date | Wed, 20 Sep 2017 09:09:16 +0200 |
| |
>> @@ -555,17 +553,13 @@ static int s2250_probe(struct i2c_client *client, >> /* initialize the audio */ >> if (write_regs(audio, aud_regs) < 0) { >> dev_err(&client->dev, "error initializing audio\n"); >> - goto fail; >> + goto e_io; > > Preserve the error code.
Do you suggest then to adjust the implementation of the function "write_regs" so that a more meaningful value would be used instead of the failure indication "-1"?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/usb/go7007/s2250-board.c?h=v4.14-rc1#n302 http://elixir.free-electrons.com/linux/v4.14-rc1/source/drivers/media/usb/go7007/s2250-board.c#L298
Regards, Markus
| |