lkml.org 
[lkml]   [2017]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe()
On Wed, Sep 20, 2017 at 09:09:16AM +0200, SF Markus Elfring wrote:
> >> @@ -555,17 +553,13 @@ static int s2250_probe(struct i2c_client *client,
> >> /* initialize the audio */
> >> if (write_regs(audio, aud_regs) < 0) {
> >> dev_err(&client->dev, "error initializing audio\n");
> >> - goto fail;
> >> + goto e_io;
> >
> > Preserve the error code.
>
> Do you suggest then to adjust the implementation of the function "write_regs"
> so that a more meaningful value would be used instead of the failure indication "-1"?
>

If you want to, yeah, that would be good.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-09-20 11:14    [W:0.044 / U:0.844 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site