[lkml]   [2017]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH 5/9] ASoC: max98927: Removed obsolete variables
>-----Original Message-----
>From: Mark Brown []
>Sent: Thursday, August 31, 2017 4:54 AM
>To: Ryan Lee <>
>;; linux-
>Subject: Re: [PATCH 5/9] ASoC: max98927: Removed obsolete variables
>On Mon, Aug 28, 2017 at 04:30:57PM -0700, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <>
>Why are these variables obsolete? If their use was removed in earlier patches in
>the series they should be handled in that patch, if they're just unused say so. In
>general your changelogs could really benefit from being a bit longer and
>explaining why changes are being made.
>> mode change 100644 => 100755 sound/soc/codecs/max98927.h
>This also changes the permissions to be executable which isn't what we want.

Thank you for your comment.
I wanted to remove these variables because it have never been referred in max98927.c from the beginning.

 \ /
  Last update: 2017-09-01 23:39    [W:0.111 / U:0.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site