lkml.org 
[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/9] ASoC: max98927: Removed obsolete variables
On Mon, Aug 28, 2017 at 04:30:57PM -0700, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>

Why are these variables obsolete? If their use was removed in earlier
patches in the series they should be handled in that patch, if they're
just unused say so. In general your changelogs could really benefit
from being a bit longer and explaining why changes are being made.

> mode change 100644 => 100755 sound/soc/codecs/max98927.h

This also changes the permissions to be executable which isn't what we
want.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-08-31 13:54    [W:0.779 / U:0.384 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site