Messages in this thread Patch in this message | | | Date | Thu, 17 Aug 2017 18:12:34 -0500 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH] media: venus: fix duplicated code for different branches |
| |
Refactor code in order to avoid identical code for different branches.
This issue was detected with the help of Coccinelle.
Addresses-Coverity-ID: 1415317 Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- This code was reported by Coverity and it was tested by compilation only. Please, verify if this is an actual bug.
drivers/media/platform/qcom/venus/helpers.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c index 5f4434c..8a5c467 100644 --- a/drivers/media/platform/qcom/venus/helpers.c +++ b/drivers/media/platform/qcom/venus/helpers.c @@ -240,11 +240,7 @@ static void return_buf_error(struct venus_inst *inst, { struct v4l2_m2m_ctx *m2m_ctx = inst->m2m_ctx; - if (vbuf->vb2_buf.type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) - v4l2_m2m_src_buf_remove_by_buf(m2m_ctx, vbuf); - else - v4l2_m2m_src_buf_remove_by_buf(m2m_ctx, vbuf); - + v4l2_m2m_src_buf_remove_by_buf(m2m_ctx, vbuf); v4l2_m2m_buf_done(vbuf, VB2_BUF_STATE_ERROR); } -- 2.5.0
| |