Messages in this thread | | | Subject | Re: [PATCH v1 1/1] KVM: add missing kvm_put_kvm in case of failure | From | Paolo Bonzini <> | Date | Tue, 27 Jun 2017 15:40:03 +0200 |
| |
On 27/06/2017 15:34, Al Viro wrote: > On Tue, Jun 27, 2017 at 01:57:16PM +0200, Claudio Imbrenda wrote: >> If I'm not missing anything, in case kvm_create_vm_debugfs fails, we >> will have a memory leak due to not freeing the kvm object. >> >> A call to kvm_put_kvm was accidentally removed from an error handling in >> commit 506cfba9e726 ("KVM: don't use anon_inode_getfd() before possible failures") >> >> This patch simply restores the call to kvm_put_kvm, so that the kvm >> object is destroyed before returning an error. >> >> Signed-off-by: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com> >> Fixes: 506cfba9e726 ("KVM: don't use anon_inode_getfd() before possible failures") > > What you are missing is that by that point we have file->f_op already > set, with ->release() being kvm_vm_release(). It will be called by > final fput(), and that's what will do your "missing" kvm_put_kvm(). > > IOW, NAK - removal was not accidental and you've just introduced > double-put there.
Better add a comment, I'll reuse your wording. Thanks.
Paolo
| |