lkml.org 
[lkml]   [2017]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/1] KVM: add missing kvm_put_kvm in case of failure
From
Date


On 27/06/2017 15:50, Al Viro wrote:
>> Queued, thanks.
> It's broken. Look: once we are past the anon_inode_getfile(), the
> reference we held on kvm is transferred into new struct file. After
> that point we don't drop kvm - we drop file. And as long as that
> file is held, it will keep holding what used to be our reference to
> kvm. Once all references to file are gone, its ->release() will be
> called and that's where kvm reference in it will be dropped.
>
> IOW, this patch introduces a double-put.

Yup, I've noticed your other reply (hopefully would have noticed during
regression testing). Thanks Al.

Paolo

\
 
 \ /
  Last update: 2017-06-27 15:58    [W:0.035 / U:0.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site