Messages in this thread | | | Subject | Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control | From | Philipp Zabel <> | Date | Mon, 19 Jun 2017 14:18:33 +0200 |
| |
Hi Vivek,
On Tue, 2017-06-13 at 12:16 +0530, Vivek Gautam wrote: [...] > > @@ -102,18 +94,6 @@ static inline struct reset_control *__devm_reset_control_get( > > return optional ? NULL : ERR_PTR(-ENOTSUPP); > > } > > > > -static inline > > -int reset_control_array_assert(struct reset_control_array *resets) > > -{ > > - return 0; > > -} > > - > > -static inline > > -int reset_control_array_deassert(struct reset_control_array *resets) > > -{ > > - return 0; > > -} > > - > > static inline struct reset_control_array * > > This has to return just 'struct reset_control *'. > That should resolve kbuild errors. > > Rest looks good to me. > Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Thanks, I had already fixed this locally, prompted by the kbuild test robot. I'll send a v6. I would like to merge this patch into the first "reset: Add APIs to manage array of resets" patch, if that's ok with you.
regards Philipp
| |