Messages in this thread | | | Subject | Re: [PATCH v3 4/7] x86: switch atomic.h to use atomic-instrumented.h | From | Andrey Ryabinin <> | Date | Fri, 16 Jun 2017 18:54:03 +0300 |
| |
On 06/06/2017 01:11 PM, Dmitry Vyukov wrote: > Add arch_ prefix to all atomic operations and include > <asm-generic/atomic-instrumented.h>. This will allow > to add KASAN instrumentation to all atomic ops. > > Signed-off-by: Dmitry Vyukov <dvyukov@google.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: kasan-dev@googlegroups.com > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: x86@kernel.org > > ---
> -static __always_inline void atomic_set(atomic_t *v, int i) > +static __always_inline void arch_atomic_set(atomic_t *v, int i) > { > + /* > + * We could use WRITE_ONCE_NOCHECK() if it exists, similar to > + * READ_ONCE_NOCHECK() in arch_atomic_read(). But there is no such > + * thing at the moment, and introducing it for this case does not > + * worth it. > + */
I'd rather remove this comment. I woudn't say that WRITE_ONCE() here looks confusing and needs comment. Also there is no READ_ONCE_NOCHECK() in arch_atomic_read() anymore.
Otherwise, Reviewed-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> WRITE_ONCE(v->counter, i); > } >
| |