Messages in this thread Patch in this message | | | From | Yisheng Xie <> | Subject | [PATCH] ion: hisilicon: check the right value after ion_heap_create | Date | Thu, 4 May 2017 22:45:33 +0800 |
| |
From: Yisheng Xie <xieyisheng1@huawei.com>
It should check ipdev->heaps[i] whether it is error or null instead of ipdev->heaps, after ion_heap_create() for ipdev->heaps[i].
Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> --- drivers/staging/android/ion/hisilicon/hi6220_ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c index 0de7897..7f8eda5 100644 --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c @@ -66,7 +66,7 @@ static int hi6220_ion_probe(struct platform_device *pdev) for (i = 0; i < ipdev->data->nr; i++) { ipdev->heaps[i] = ion_heap_create(&ipdev->data->heaps[i]); - if (!ipdev->heaps) { + if (IS_ERR_OR_NULL(ipdev->heaps[i])) { ion_destroy_platform_data(ipdev->data); return -ENOMEM; } -- 1.9.1
| |