Messages in this thread | | | From | Dong Aisheng <> | Date | Thu, 13 Apr 2017 21:44:42 +0800 | Subject | Re: [PATCH] regulator: core: Allow dummy regulators for supplies |
| |
Hi Mark,
On Thu, Apr 13, 2017 at 8:20 PM, Mark Brown <broonie@kernel.org> wrote: > On Wed, Apr 12, 2017 at 03:33:14PM +0000, A.S. Dong wrote: > >> Now we allow a supply to be a dummy regulator. But due to >> fc42112c0eaa ("regulator: core: Propagate voltage changes to supply regulators") >> which supports propagate voltage change to supply regulator, >> then it will certainly fail if we want to configure a dummy supply. >> >> I tried a quick fix as follows and test seemed ok. > >> - if (rdev->supply && (rdev->desc->min_dropout_uV || >> + if (rdev->supply && rdev->supply->rdev != dummy_regulator_rdev && >> + (rdev->desc->min_dropout_uV || > >> Not sure if it's a sufficient fix. >> Please help check it. > > Ah, of course. That'll work but I don't think it's the best solution - > there are some other regulators that also won't support setting voltages > but might get used as supplies so we should do something based on the > properties of the regulator rather than based specifically on the dummy > regulator. Let me see..
Yes, i was also wondering that.. Let's waiting for you...
Thanks
Regards Dong Aisheng
| |