lkml.org 
[lkml]   [2017]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: core: Allow dummy regulators for supplies
On Wed, Apr 12, 2017 at 03:33:14PM +0000, A.S. Dong wrote:

> Now we allow a supply to be a dummy regulator. But due to
> fc42112c0eaa ("regulator: core: Propagate voltage changes to supply regulators")
> which supports propagate voltage change to supply regulator,
> then it will certainly fail if we want to configure a dummy supply.
>
> I tried a quick fix as follows and test seemed ok.

> - if (rdev->supply && (rdev->desc->min_dropout_uV ||
> + if (rdev->supply && rdev->supply->rdev != dummy_regulator_rdev &&
> + (rdev->desc->min_dropout_uV ||

> Not sure if it's a sufficient fix.
> Please help check it.

Ah, of course. That'll work but I don't think it's the best solution -
there are some other regulators that also won't support setting voltages
but might get used as supplies so we should do something based on the
properties of the regulator rather than based specifically on the dummy
regulator. Let me see...
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-04-13 14:22    [W:0.057 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site