lkml.org 
[lkml]   [2017]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly
Date
devm_input_allocate_device() already causes the supplied struct device
to be set as the parent of the input device, so doing it again is
redundant.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
---
This patch needs my recent intel-hid cleanup series to apply cleanly.
In other words, it should apply on top of testing, but not for-next.

drivers/platform/x86/intel-hid.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index 5eab31659cba..b40059aba856 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -152,7 +152,6 @@ static int intel_hid_input_setup(struct platform_device *device)
if (ret)
return ret;

- priv->input_dev->dev.parent = &device->dev;
priv->input_dev->name = "Intel HID events";
priv->input_dev->id.bustype = BUS_HOST;

@@ -173,7 +172,6 @@ static int intel_button_array_input_setup(struct platform_device *device)
if (ret)
return ret;

- priv->array->dev.parent = &device->dev;
priv->array->name = "Intel HID 5 button array";
priv->array->id.bustype = BUS_HOST;

--
2.12.0
\
 
 \ /
  Last update: 2017-03-09 11:10    [W:0.049 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site