lkml.org 
[lkml]   [2017]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectAbout boot time Tux logo with -EPROBE_DEFER
Date

Hi

I want to ask you about boot time Tux logo.

For some reasons, current our video driver returns -EPROBE_DEFER when
probe timing, but logo init function doesn't care it.
Thus, our kernel can't have logo when boot time.

I think this is not only our issue, but general issue ?

Thus, I think logo init function should care about -EPROBE_DEFER
or something. In our quick hack, this issue was solved by below patch,
but I don't know this is OK.

So, how to solve this issue ? do you have nice idea ?
or can maintainer accept below patch ?

-------------------
diff --git a/drivers/video/logo/logo.c b/drivers/video/logo/logo.c
index b6bc4a0bda2a..4d50bfd13e7c 100644
--- a/drivers/video/logo/logo.c
+++ b/drivers/video/logo/logo.c
@@ -34,7 +34,7 @@ static int __init fb_logo_late_init(void)
return 0;
}

-late_initcall(fb_logo_late_init);
+late_initcall_sync(fb_logo_late_init);

/* logo's are marked __initdata. Use __ref to tell
* modpost that it is intended that this function uses data
-------------------
Best regards
---
Kuninori Morimoto
\
 
 \ /
  Last update: 2017-03-07 02:26    [W:0.523 / U:1.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site